Re: Hide exposed impl detail of wchar.c

From: Eric Ridge <eebbrr(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Jubilee Young <workingjubilee(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Hide exposed impl detail of wchar.c
Date: 2023-11-21 15:14:32
Message-ID: 8455C6A3-786E-41DC-A004-B576519E602F@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Nov 20, 2023, at 7:10 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
>
> What I don't quite get is why SIMD headers are particularly more problematic
> than others - there's other headers that are compiler specific?

The short answer is the rust-based bindings generation tool pgrx uses (bindgen) is a little brain dead and gets confused when there’s multiple compiler builtins headers on the host.

This simd header is the first of its kind we’ve run across that’s exposed via Postgres’ “public api”. And bindgen wants to follow all the includes, it gets confused, picks the wrong one, and then errors happen.

And I don’t know that it makes much sense for Postgres to include such a header into 3rd-party code anyways.

I think Jubilee is also working with them to fix this, but we’re hoping Jubilee’s patch here (or similar) can get merged so we can clear our build drama.

eric

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2023-11-21 15:41:35 Re: Annoying build warnings from latest Apple toolchain
Previous Message Aleksander Alekseev 2023-11-21 15:01:30 Re: How to accurately determine when a relation should use local buffers?