Re: Uninitialized-variable warnings in nbtinsert.c

Peter Geoghegan <pg(at)bowt(dot)ie> writes:
> On Sat, Jun 13, 2020 at 9:17 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I scraped the buildfarm's compiler warnings today, as I do from
>> time to time, and I noticed that half a dozen animals that normally
>> don't report any uninitialized-variable warnings are complaining
>> about "curitup" in _bt_doinsert.

> (Clearly you meant _bt_check_unique(), not _bt_doinsert().)

Ah, right. I was looking at calliphoridae's complaint when I wrote that:

In file included from /home/andres/build/buildfarm-calliphoridae/HEAD/pgsql.build/../pgsql/src/backend/access/nbtree/nbtinsert.c:18:
/home/andres/build/buildfarm-calliphoridae/HEAD/pgsql.build/../pgsql/src/backend/access/nbtree/nbtinsert.c: In function \xe2\x80\x98_bt_doinsert\xe2\x80\x99:

but it must have inlined some stuff first. (A lot of the other
complainers are fingering inline functions in nbtree.h, which
is even less helpful.)

> Thanks for bringing this to my attention. I'll push a commit that
> initializes curitup shortly, targeting both the v13 branch and the
> master branch.

Thanks!

regards, tom lane