| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jesse Zhang <sbjesse(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Residual cpluspluscheck issues |
| Date: | 2020-09-30 15:47:18 |
| Message-ID: | 844760.1601480838@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jesse Zhang <sbjesse(at)gmail(dot)com> writes:
> So it's been 17 months since you sent this email, so I'm not sure that
> nothing has happened (off list or in the code base), but...
Well, we fixed the case that was discussed at the time [1].
I'm not exactly convinced about removing the register keywords in
s_lock.h. Those are all associated with asm blocks, which are already
extremely C/GCC specific; complaining that the register declarations
aren't portable seems to be missing the forest for the trees.
BTW, grepping my local tree says that plperl/ppport.h also has some
register variables, which is something we have no control over.
regards, tom lane
[1] https://git.postgresql.org/gitweb/?p=postgresql.git&a=commitdiff&h=232720be9
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-09-30 15:53:44 | Re: VACUUM PARALLEL option vs. max_parallel_maintenance_workers |
| Previous Message | Jesse Zhang | 2020-09-30 15:20:45 | Re: Residual cpluspluscheck issues |