Re: Refactor compile-time assertion checks for C/C++

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Georgios Kokolatos <gkokolatos(at)pm(dot)me>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Refactor compile-time assertion checks for C/C++
Date: 2020-03-12 13:43:54
Message-ID: 8447.1584020634@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> So, should we add a reference about both in the new comment? I would
> actually not add them, so I have used your suggestion in the attached,
> but the comment block above does that for _Static_assert(). Do you
> think it is better to add some references to some of those compilers
> (say GCC 4.3, MSVC)? Just stick with your suggestion? Or stick with
> your version and replace the reference to GCC 4.6 with something like
> "recent compilers"?

I don't feel a need to expend a whole lot of sweat there. The existing
text is fine, it just bugged me that the code deals with three cases
while the comment block only acknowledged two. So I'd just go with
what you have in v3.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-03-12 13:48:03 Re: Add an optional timeout clause to isolationtester step.
Previous Message Pavel Stehule 2020-03-12 13:41:17 Re: SQL/JSON: functions