From: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
---|---|
To: | <fabriziomello(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, "[pgdg] Robert Haas" <robertmhaas(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Minimal logical decoding on standbys |
Date: | 2021-03-24 06:56:51 |
Message-ID: | 842d60ce-99e6-f35e-8c92-0cd49381326e@amazon.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 3/23/21 11:05 PM, Fabrízio de Royes Mello wrote:
>
> >
> > done in v13 attached.
> >
>
> All tests passed and everything looks good to me... just a final
> minor fix on regression tests:
>
> diff --git a/src/test/regress/expected/rules.out
> b/src/test/regress/expected/rules.out
> index b0e17d4e1d..961ec869a6 100644
> --- a/src/test/regress/expected/rules.out
> +++ b/src/test/regress/expected/rules.out
> @@ -1869,9 +1869,9 @@ pg_stat_database_conflicts| SELECT d.oid AS datid,
> pg_stat_get_db_conflict_tablespace(d.oid) AS confl_tablespace,
> pg_stat_get_db_conflict_lock(d.oid) AS confl_lock,
> pg_stat_get_db_conflict_snapshot(d.oid) AS confl_snapshot,
> - pg_stat_get_db_conflict_logicalslot(d.oid) AS confl_logicalslot,
> pg_stat_get_db_conflict_bufferpin(d.oid) AS confl_bufferpin,
> - pg_stat_get_db_conflict_startup_deadlock(d.oid) AS confl_deadlock
> + pg_stat_get_db_conflict_startup_deadlock(d.oid) AS confl_deadlock,
> + pg_stat_get_db_conflict_logicalslot(d.oid) AS confl_logicalslot
> FROM pg_database d;
> pg_stat_gssapi| SELECT s.pid,
> s.gss_auth AS gss_authenticated,
>
> We moved "pg_stat_database_conflicts.confl_logicalslot" to the end of
> the column list but forgot to change the regression test expected result.
Thanks for pointing out, fixed in v14 attached.
Bertrand
Attachment | Content-Type | Size |
---|---|---|
v14-0005-Doc-changes-describing-details-about-logical-dec.patch | text/plain | 1.8 KB |
v14-0004-New-TAP-test-for-logical-decoding-on-standby.patch | text/plain | 20.9 KB |
v14-0003-Handle-logical-slot-conflicts-on-standby.patch | text/plain | 26.8 KB |
v14-0002-Add-info-in-WAL-records-in-preparation-for-logic.patch | text/plain | 19.7 KB |
v14-0001-Allow-logical-decoding-on-standby.patch | text/plain | 9.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2021-03-24 07:09:13 | Re: pl/pgsql feature request: shorthand for argument and local variable references |
Previous Message | Justin Pryzby | 2021-03-24 06:24:47 | Re: PoC/WIP: Extended statistics on expressions |