From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Marko Kreen <marko(at)l-t(dot)ee> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: 4 pgcrypto regressions failures - 1 unsolved |
Date: | 2005-07-11 14:39:26 |
Message-ID: | 8429.1121092766@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Marko Kreen <marko(at)l-t(dot)ee> writes:
> On Mon, Jul 11, 2005 at 10:10:12AM -0400, Tom Lane wrote:
>> The following addition to the patch shuts up gcc with openssl 0.9.7a,
>> but I'm not sure if it will break anything with older openssl ---
>> comments?
> They won't matter on older OpenSSL, as the macros will recast
> again. But on 0.9.7e the signature is:
> void DES_ecb3_encrypt(const unsigned char *input, unsigned char *output,
> DES_key_schedule *ks1,DES_key_schedule *ks2,
> DES_key_schedule *ks3, int enc);
> so it seems to me that with your patch the warnings will appear
> on newer OpenSSL. (Confirmed)
Grumble --- you're right. It's probably not worth ifdef'ing the code to
suppress the warnings on 0.9.7a ...
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-07-11 15:09:06 | Re: 4 pgcrypto regressions failures - 1 unsolved |
Previous Message | Marko Kreen | 2005-07-11 14:27:02 | Re: 4 pgcrypto regressions failures - 1 unsolved |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-07-11 15:09:06 | Re: 4 pgcrypto regressions failures - 1 unsolved |
Previous Message | Marko Kreen | 2005-07-11 14:27:02 | Re: 4 pgcrypto regressions failures - 1 unsolved |