Re: msys inet_pton strangeness

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: msys inet_pton strangeness
Date: 2024-09-28 15:49:06
Message-ID: 841268.1727538546@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> It's complaining like this:

> C:/tools/xmsys64/home/pgrunner/bf/root/REL_15_STABLE/pgsql/src/interfaces/libpq/fe-secure-common.c:219:21: error: implicit declaration of function 'inet_pton'; did you mean 'inet_aton'? [-Wimplicit-function-declaration]
> 219 | if (inet_pton(AF_INET6, host, &addr) == 1)
> | ^~~~~~~~~

> configure has determined that we have inet_pton, and I have repeated the
> test manually.

configure's test is purely a linker test. It does not check to see
where/whether the function is declared. Meanwhile, the compiler is
complaining that it doesn't see a declaration. So the problem
probably can be fixed by adding an #include, but you'll need to
figure out what.

I see that our other user of inet_pton, fe-secure-openssl.c,
has a rather different #include setup than fe-secure-common.c;
does it compile OK?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sutou Kouhei 2024-09-28 15:56:45 Re: Make COPY format extendable: Extract COPY TO format implementations
Previous Message jian he 2024-09-28 14:40:00 Re: general purpose array_sort