| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, 蔡梦娟(玊于) <mengjuan(dot)cmj(at)alibaba-inc(dot)com>, Jakub Wartak <Jakub(dot)Wartak(at)tomtom(dot)com> |
| Subject: | Re: prevent immature WAL streaming |
| Date: | 2021-09-02 00:04:17 |
| Message-ID: | 83C102B9-991B-417D-80C0-193AC3887C0B@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/1/21, 10:06 AM, "Andres Freund" <andres(at)anarazel(dot)de> wrote:
> On 2021-09-01 15:01:43 +0900, Fujii Masao wrote:
>> Thanks for clarifying that! Unless I misunderstand that, when recovery ends
>> at a partially-flushed segment-spanning record, it sets
>> XLP_FIRST_IS_ABORTED_PARTIAL in the next segment before starting writing
>> new WAL data there. Therefore XLP_FIRST_IS_CONTRECORD or
>> XLP_FIRST_IS_ABORTED_PARTIAL must be set in the next segment following
>> a partially-flushed segment-spanning record. If none of them is set,
>> the validation code in recovery should report an error.
>
> Right. With the small addition that I think we shouldn't just do this for
> segment spanning records, but for all records spanning pages.
This approach seems promising. I like that it avoids adding extra
work in the hot path for writing WAL. I'm assuming it won't be back-
patchable, though.
Nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2021-09-02 00:09:49 | Re: [PATCH] test/ssl: rework the sslfiles Makefile target |
| Previous Message | Ranier Vilela | 2021-09-02 00:01:03 | Re: Postgres Win32 build broken? |