| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Jeremy Drake <pgsql(at)jdrake(dot)com> |
| Subject: | Re: Re: [COMMITTERS] pgsql: GIN index build's allocatedMemory counter needs to be long, not |
| Date: | 2007-11-18 20:57:59 |
| Message-ID: | 8337.1195419479@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Jeremy Drake wrote:
>> I don't know if this has been discussed before, but you are aware that it
>> is not dictated by the C standard that sizeof(long) == sizeof(void*)?
> Yes, and there is lots of work left to do to support that.
Yeah. The current code convention is to use "long" when counting space
allocations --- see tuplesort.c for instance --- so I made this do
likewise. At some point we should try to migrate away from that,
but not today.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | User Dim | 2007-11-18 23:04:48 | pgloader - pgloader: Adding the 'input_encoding' option in the |
| Previous Message | Peter Eisentraut | 2007-11-18 20:46:40 | Re: Re: [COMMITTERS] pgsql: GIN index build's allocatedMemory counter needs to be long, not |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matt Magoffin | 2007-11-19 07:52:22 | possible to create multivalued index from xpath() results in 8.3? |
| Previous Message | Peter Eisentraut | 2007-11-18 20:46:40 | Re: Re: [COMMITTERS] pgsql: GIN index build's allocatedMemory counter needs to be long, not |