| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Catching resource leaks during WAL replay |
| Date: | 2013-03-27 23:01:25 |
| Message-ID: | 8316.1364425285@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> On 27 March 2013 20:40, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> wrote:
>> While looking at bug #7969, it occurred to me that it would be nice if we
>> could catch resource leaks in WAL redo routines better. It would be useful
>> during development, to catch bugs earlier, and it could've turned that
>> replay-stopping error into a warning.
> I'm inclined to think that the overhead isn't worth the trouble. This
> is the only bug of its type we had in recent years.
I agree that checking for resource leaks after each WAL record seems
too expensive compared to what we'd get for it. But perhaps it's worth
making a check every so often, like at restartpoints?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2013-03-27 23:09:22 | Re: Catching resource leaks during WAL replay |
| Previous Message | Dean Rasheed | 2013-03-27 22:39:52 | Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL) |