What happened to jsonb's JENTRY_ISFIRST?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: What happened to jsonb's JENTRY_ISFIRST?
Date: 2014-08-13 22:47:42
Message-ID: 8305.1407970062@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

jsonb.h claims that the high order bit of a JEntry word is set on the
first element of a JEntry array. However, AFAICS, JBE_ISFIRST() is
not used anywhere, which is a good thing because it refers to a constant
JENTRY_ISFIRST that's not defined anywhere. Is this comment just a leftover
from a convention that's been dropped, or is it still implemented but not
via this macro?

If the bit is unused now, should we be worrying about reclaiming it for
better use? Like say allowing jsonb's to be larger than just a quarter
of the maximum datum size?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-08-13 23:04:44 Re: Proposal to add a QNX 6.5 port to PostgreSQL
Previous Message Baker, Keith [OCDUS Non-J&J] 2014-08-13 22:38:54 Re: Proposal to add a QNX 6.5 port to PostgreSQL