From: | Michael Glaesemann <grzm(at)seespotcode(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: change name of redirect_stderr? |
Date: | 2007-08-14 19:13:21 |
Message-ID: | 829EC86B-A0DE-49C3-8704-21AF55E8173C@seespotcode.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Aug 14, 2007, at 12:40 , Tom Lane wrote:
> Josh Berkus <josh(at)agliodbs(dot)com> writes:
>>> The problem here is that "log" seems to be a verb in "log_collector"
>>> which is what makes it confusing. So we need another verb to
>>> make it
>>> clear that "log" is not one. This is not a problem with
>>> "autovacuum"
>>> because that one cannot be confused with a verb.
>>>
>>> start_log_collector still gets my vote.
>
>> log_collector_enable or log_collector_start or even log_redirect.
>> But
>> something with log_*
>
> I'm voting with Alvaro on this. All of your suggestions are confusing
> because "log" looks like the verb, which it is not. Specifically,
> they
> sound like what the switch does is to cause a log message to be
> emitted
> about some action that would occur anyway.
AIUI, if the-GUC-yet-to-be-named is not enabled, no logging is done
at all: messages are just sent to stderr. Why something simple like
enable_logging or start_logger?
Michael Glaesemann
grzm seespotcode net
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2007-08-14 19:15:44 | Re: tsearch2 in PostgreSQL 8.3? |
Previous Message | Bruce Momjian | 2007-08-14 19:00:04 | tsearch2 in PostgreSQL 8.3? |