Re: Tablespace patch review

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Tablespace patch review
Date: 2004-06-19 02:08:28
Message-ID: 8286.1087610908@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> How useful will oid2name be if it doesn't understand about tablespaces?
>> I dunno how it ought to be changed, but surely it needs some thought.

> I assume we just need to add a tablespace display when run with no args,
> and a -s option to display _with_ -d to display only objects in that
> database. We could go fancy and spin through all the databases and list
> the datbase name and objects in that tablespace.

I should think that the table-level display ought to show both the
relfilenode and tablespace OIDs for each table.

> Given the number of open items for 7.5, I am thinking of keeping this
> for post-feature freeze. Both are contrib.

Right, I doubt Marc will object to fixing contrib stuff after feature
freeze ...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gavin Sherry 2004-06-19 02:10:00 Re: Minor DROP TABLESPACE issue
Previous Message Tom Lane 2004-06-19 02:04:44 Re: Minor DROP TABLESPACE issue

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-06-19 02:20:57 Re: Tablespace patch review
Previous Message Bruce Momjian 2004-06-19 01:47:43 Re: Tablespace patch review