From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: jsonapi type fixups |
Date: | 2024-06-21 06:01:11 |
Message-ID: | 828453a2-7c19-4d85-a141-9e697b813366@eisentraut.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 20.06.24 14:05, Andrew Dunstan wrote:
> On 2024-06-18 Tu 7:48 AM, Peter Eisentraut wrote:
>> I have this patch series that fixes up the types of the new
>> incremental JSON API a bit. Specifically, it uses "const" throughout
>> so that the top-level entry points such as pg_parse_json_incremental()
>> can declare their arguments as const char * instead of just char *.
>> This just works, it doesn't require any new casting tricks. In fact,
>> it removes a few unconstify() calls.
>>
>> Also, a few arguments and variables that relate to object sizes should
>> be size_t rather than int. At this point, this mainly makes the API
>> better self-documenting. I don't think it actually works to parse
>> larger than 2 GB chunks (not tested).
> I think this is mostly OK.
> It would also be nice to reword the comment at line 3142 of jsonfuncs.c,
> so it can still fit on one line.
Agreed. Committed with that fixup.
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2024-06-21 06:18:22 | Re: 001_rep_changes.pl fails due to publisher stuck on shutdown |
Previous Message | David G. Johnston | 2024-06-21 05:38:24 | Re: ON ERROR in json_query and the like |