From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | "Daniel Westermann (DWE)" <daniel(dot)westermann(at)dbi-services(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pg_upgrade, tables_with_oids.txt -> tables_with_oids.sql? |
Date: | 2022-11-22 10:59:15 |
Message-ID: | 825FC57F-2B2D-4E54-BB21-EDCA91FADCC5@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 6 Nov 2022, at 09:48, Daniel Westermann (DWE) <daniel(dot)westermann(at)dbi-services(dot)com> wrote:
> as I've just upgraded an instance which contained tables "WITH OIDS" I wonder if it would make sense if pg_upgrade directly creates a script to fix those. I know it is easy to that with e.g. sed over tables_with_oids.txt but it would be more convenient to have the script generated directly.
For the checks on the old system we don't generate any scripts, only reports of
problems. I don't recall the reasoning but I would assume it stems from some
checks being up to the user to deal with, no one-size-fits-all script is
possible. Having them all generate reports rather than scripts makes that
consistent across the old checks.
In this particular case we probably could safely make a script, but if we we'd
need to expand testing to validate it etc so I'm not sure it's worth it.
--
Daniel Gustafsson https://vmware.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Maxim Orlov | 2022-11-22 11:04:27 | Re: [PATCH] Add initial xid/mxid/mxoff to initdb |
Previous Message | Ted Yu | 2022-11-22 10:51:44 | Re: [CAUTION!! freemail] Re: Partial aggregates pushdown |