| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: 9.5 BLOCKER: regrole and regnamespace and quotes |
| Date: | 2016-01-04 06:09:27 |
| Message-ID: | 8232.1451887767@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> Attached is an updated patch which passes
> check-world in my environment.
Pushed with trivial cosmetic changes to the code, and slightly more
extensive work on the regression test cases.
It strikes me that there might be an argument for returning NULL
rather than raising an error for to_regrole('foo.bar') and
to_regnamespace('foo.bar'). On the other hand, input-syntax issues
result in errors for the other to_reg* functions, so it might
be fine as-is. In any case, relaxing the error rather than adding
one is much easier to justify as a future change, so I left it
as Jim/Michael had it for the moment.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-01-04 06:10:19 | Re: 9.5 BLOCKER: regrole and regnamespace and quotes |
| Previous Message | Haribabu Kommi | 2016-01-04 05:43:55 | Re: Multi-tenancy with RLS |