Re: [PATCH] In case module has wrong magic, report exact problem

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Marko Kreen <markokr(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] In case module has wrong magic, report exact problem
Date: 2008-09-03 22:36:44
Message-ID: 8231.1220481404@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Marko Kreen <markokr(at)gmail(dot)com> writes:
> In case module and server magic blocks do not match
> report exact parameters that differ.

Applied with revisions --- your patch produced a message that wasn't
localizable and didn't follow the style guidelines. Also it assumed
that all the fields would be plain integer values, which isn't true
even today.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua Drake 2008-09-03 22:43:36 Re: [PATCH] Cleanup of GUC units code
Previous Message Hannu Krosing 2008-09-03 22:26:44 Re: [PATCH] Cleanup of GUC units code