| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: logical replication launcher crash on buildfarm |
| Date: | 2017-03-28 02:51:53 |
| Message-ID: | 8213.1490669513@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> I wasn't thinking of introducing bgw_builtin_id. My idea was just
> along the lines of
> if (bgw_library_name == NULL && bgw_function_name != NULL)
> {
> if (strcmp(bgw_function_name, "ParallelQueryMain") == 0)
> ParallelQueryMain(blah);
> else if (strcmp(bgw_function_name, "LogicalReplicationMain") == 0)
> LogicalReplicationMain(blah);
> }
> I think something like that is certainly better for the back-branches,
> because it doesn't cause an ABI break. But I think it would also be
> fine for master.
That seems perfectly reasonable from here: surely the cost of a couple
of strcmp's is trivial in comparison to a process launch.
We can redesign the API whenever this way starts getting unwieldy,
but that's likely to be quite some time away.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-03-28 02:52:02 | Re: O(1) DSM handle operations |
| Previous Message | Bruce Momjian | 2017-03-28 02:51:13 | Re: standardized backwards incompatibility tag for commits |