| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: thread-safety: gmtime_r(), localtime_r() |
| Date: | 2024-08-16 15:43:00 |
| Message-ID: | 81b0dc6d-fbde-4ae7-84ee-eb83edbc54dc@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here is an updated patch version.
I have changed the backend call from localtime() to gmtime() but then
also to gmtime_r().
I moved the _POSIX_C_SOURCE definition for MinGW from the header file to
a command-line option (-D_POSIX_C_SOURCE). This matches the treatment
of _GNU_SOURCE and similar.
I think this is about as good as it's going to get, and we need it to
be, so I propose to commit this version if there are no further concerns.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-thread-safety-gmtime_r-localtime_r.patch | text/plain | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2024-08-16 15:52:38 | Re: BUG #18348: Inconsistency with EXTRACT([field] from INTERVAL); |
| Previous Message | Tom Lane | 2024-08-16 15:37:55 | Re: BUG #18348: Inconsistency with EXTRACT([field] from INTERVAL); |