Re: remaining sql/json patches

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, John Naylor <johncnaylorls(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Amit Langote <amitlangote09(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: remaining sql/json patches
Date: 2023-11-29 20:24:01
Message-ID: 81FCB42D-6B0D-494D-8430-3F0F8F877DF0@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Nov 29, 2023, at 2:41 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Hi,
>
>> On 2023-11-29 14:21:59 -0500, Andrew Dunstan wrote:
>> On 2023-11-29 We 12:42, Andres Freund wrote:
>>>> I do have a CFLAGS setting, but for meson I used '-Ddebug=true' and no
>>>> buildtype or optimization setting. However, I see that in meson.build we're
>>>> defaulting to "buildtype=debugoptimized" as opposed to the standard meson
>>>> "buildtype=debug", so I guess that accounts for it.
>>>>
>>>> Still getting used to this stuff.
>>> What I meant was whether you set CFLAGS for the *autoconf* build,
>>
>> That's what I meant too.
>>
>>> because that
>>> will result in an unoptimized build unless you explicitly add -O2 (or whatnot)
>>> to the flags. Doing benchmarking without compiler optimizations is pretty
>>> pointless.
>>>
>>
>> Right. My latest reported results should all be at -O2.
>
> Why are the results suddenly so much slower?
>
>

As I mentioned I increased the iteration count to 5000.

Cheers

Andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Matthias van de Meent 2023-11-29 20:30:32 Re: Parallel CREATE INDEX for BRIN indexes
Previous Message Pavel Stehule 2023-11-29 20:03:21 Re: Custom explain options