From: | Florian Pflug <fgp(at)phlo(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Add %z support to elog/ereport? |
Date: | 2014-01-22 03:09:42 |
Message-ID: | 8191B6A5-8EA8-423E-8846-2BFE16850DD8@phlo.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Jan21, 2014, at 18:56 , Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> Perhaps we should jettison entirely the idea of using the operating
>> system's built-in sprintf and use one of our own that has all of the
>> nice widgets we need, like a format code that's guaranteed to be right
>> for uint64 and one that's guaranteed to be right for Size. This could
>> turn out to be a bad idea if the best sprintf we can write is much
>> slower than the native sprintf on any common platforms ... and maybe
>> it wouldn't play nice with GCC's desire to check format strings.
>
> That last is a deal-breaker. It's not just whether "gcc desires" to check
> this --- we *need* that checking, because people get it wrong without it.
There's an attribute that enables this check for arbitrary functions AFAIR.
best regards,
Florian Pflug
From | Date | Subject | |
---|---|---|---|
Next Message | Jon Nelson | 2014-01-22 03:16:25 | PoC: Duplicate Tuple Elidation during External Sort for DISTINCT |
Previous Message | Tom Lane | 2014-01-22 02:59:50 | Re: proposal: hide application_name from other users |