| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Mark Dilger <hornschnorter(at)gmail(dot)com> |
| Cc: | Ranier Vilela <ranier_gyn(at)hotmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Style, remove redudant test "if (zeropadlen > 0)" |
| Date: | 2019-11-24 17:06:26 |
| Message-ID: | 8176.1574615186@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Mark Dilger <hornschnorter(at)gmail(dot)com> writes:
> On 11/24/19 8:12 AM, Ranier Vilela wrote:
>> The test "if (zeropadlen > 0)" is redundant and can be salely removed.
>> It has already been tested in the same path.
> I have not tested your patch, but it looks right to me.
Agreed, seems like an oversight in an old patch of mine. Pushed.
I concur with John's nearby complaint that you're not submitting
diffs in a useful format. The file paths are weird. Also, it's
generally proven to be a good idea to send diffs as attachments,
not embedded in-line in the email --- in-line text is far too
prone to get mangled by assorted mail programs.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2019-11-24 17:33:19 | RE: [PATCH] Style, remove redudant test "if (zeropadlen > 0)" |
| Previous Message | Tom Lane | 2019-11-24 16:40:17 | Re: [PATCH] Possible arithmetic with NULL pointer or test "stack_base_ptr != NULL" is irrelevant. |