| From: | Tobias Bussmann <t(dot)bussmann(at)gmx(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Mark Guertin <markguertin(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files |
| Date: | 2023-05-01 21:23:58 |
| Message-ID: | 817432D1-864B-449F-B895-3A829ADE2A98@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
>> [...] is a new feature and not a bugfix [...] other opinions [...]
> I am fine to hear more opinions, then.
IMHO, while generally ignoring hidden files can be seen as a change in behaviour and a new feature, specifically skipping the '.DS_Store' files is clearly a bugfix that should be backported. With checksumming enabled, pg_basebackup is simply broken on macOS, depending on whether or not you have ever browsed parts of the data directory in the Finder.
The safe solution for the back branches would be to add '{".DS_Store", false}' to the exclude_list_item arrays in backend/backup/basebackup.c, bin/pg_checksums/pg_checksums.c and bin/pg_rewind/filemap.c, but I can't judge whether this would justify using a different codepath for the older versions or not.
--
Tobias Bussmann
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kieran McCusker | 2023-05-02 10:30:16 | plpython does not honour max-rows |
| Previous Message | PG Bug reporting form | 2023-05-01 20:25:00 | BUG #17914: walsenders taking up all memory |