From: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | gcov coverage data not full with immediate stop |
Date: | 2020-05-10 16:00:00 |
Message-ID: | 816a4de5-3f15-4d66-1ec1-791cab2ca6df@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello hackers,
I've found that gcov coverage data miss some information when a postgres
node stopped in 'immediate' mode.
For example, on the master branch:
make coverage-clean; time make check -C src/test/recovery/; make
coverage-html
generates a coverage report with 106193 lines/6318 functions for me
(`make check` takes 1m34s).
But with the attached simple patch I get a coverage report with 106540
lines/6332 functions (and `make check` takes 2m5s).
(IMO, the slowdown of the test is significant.)
So if we want to make the coverage reports more precise, I see the three
ways:
1. Change the stop mode in teardown_node to fast (probably only when
configured with --enable-coverage);
2. Explicitly stop nodes in TAP tests (where it's important) -- seems
too tedious and troublesome;
3. Explicitly call __gcov_flush in SIGQUIT handler (quickdie)?
Best regards,
Alexander
Attachment | Content-Type | Size |
---|---|---|
pgnode-stop.patch | text/x-patch | 310 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-05-10 16:27:23 | Re: Another modest proposal for docs formatting: catalog descriptions |
Previous Message | Justin Pryzby | 2020-05-10 15:58:18 | Re: should INSERT SELECT use a BulkInsertState? |