Re: [PATCH] fix GIN index search sometimes losing results

Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> writes:
> For 0002-remove-calc-not-flag.patch
> The patch changes the behavior which is now considered default. This is true in RUM module and maybe in some other tsearch side modules. Applying the patch can make code more beautiful but possibly will not give some performance gain and bug is anyway fixed by patch 0001.

I'd be willing to compromise on just adding TS_EXEC_CALC_NOT to the
calls that are missing it today. But I don't see why that's really
a great idea --- it still leaves a risk-of-omission hazard for future
callers. Calculating NOTs correctly really ought to be the default
behavior.

What do you think of replacing TS_EXEC_CALC_NOT with a different
flag having the opposite sense, maybe called TS_EXEC_SKIP_NOT?
If anyone really does need that behavior, they could still get it,
but they'd have to be explicit.

> Overall I'd recommend patch 0001-make-callbacks-ternary.patch and close the issue.

The other issue we have to agree on is whether we want to sneak this
fix into v13, or wait another year for it. I feel like it's pretty
late to be making potentially API-breaking changes, but on the other
hand this is undoubtedly a bug fix.

regards, tom lane