| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, kuroda(dot)hayato(at)fujitsu(dot)com, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench bug candidate: negative "initial connection time" |
| Date: | 2021-11-02 14:11:39 |
| Message-ID: | 807355f8-cb9c-9aca-2842-6cdde07a05ab@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/11/01 23:01, Fujii Masao wrote:
>> The remainings are the changes of handling of initial connection or
>> logfile open failures. I agree to push them at least for the master.
>> But I'm not sure if they should be back-patched. Without these changes,
>> even when those failures happen, pgbench proceeds the benchmark and
>> reports the result. But with the changes, pgbench exits immediately in
>> that case. I'm not sure if there are people who expect this behavior,
>> but if there are, maybe we should not change it at least at stable branches.
>> Thought?
>
> The current behavior should be improved, but not a bug.
> So I don't think that the patch needs to be back-patched.
> Barring any objection, I will push the attached patch to the master.
Pushed. Thanks!
I also pushed the typo-fix patch that I proposed upthread.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-11-02 14:21:48 | Re: inefficient loop in StandbyReleaseLockList() |
| Previous Message | Pavel Borisov | 2021-11-02 14:04:14 | Re: Feature request for adoptive indexes |