| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees. |
| Date: | 2016-04-26 15:26:40 |
| Message-ID: | 8006.1461684400@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> writes:
> On 26 April 2016 at 04:25, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> In short, these tests suggest that we need a coding pattern like
>> this:
>> volatile float8 asin_x = asin(x);
>> return (asin_x / asin_0_5) * 30.0;
> Agreed. That looks like the least hacky way of solving the problem. I
> think it's more readable when the logic is kept local, and it's
> preferable to avoid any compiler-specific options or global flags that
> would affect other code.
OK, I've pushed a change along these lines. Peter, would you see whether
HEAD fixes it for you?
The next time somebody proposes that we can get exact results out of
floating-point arithmetic, I'm going to run away screaming.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-04-26 15:30:02 | Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees. |
| Previous Message | Tom Lane | 2016-04-26 15:24:22 | pgsql: Yet more portability hacking for degree-based trig functions. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-04-26 15:28:57 | Re: Rename max_parallel_degree? |
| Previous Message | Robert Haas | 2016-04-26 15:25:26 | Re: Suspicious behaviour on applying XLOG_HEAP2_VISIBLE. |