Re: pgsql: Fix memory leak in pgbench

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Fix memory leak in pgbench
Date: 2019-04-11 13:35:23
Message-ID: 8005.1554989723@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Thu, Apr 11, 2019 at 09:03:19AM +0200, Fabien COELHO wrote:
>> I can set up farm animals with bleeding age clang/gcc (compiled weekly from
>> sources) with -Werror (seawasp & moonjelly are already running with those
>> but without -Werror).

> If possible, I would not recommend using compiled versions from
> source, but just the latest stable versions released for gcc and
> clang. Even if this can catch up compiler bugs using Postgres code at
> a very early stage, the false positives induced have been proving to
> hurt because of the time investigations took to determine if this was
> a problem on our side or not.

Yeah, I'm not excited about having to expend effort on working around
warnings seen only in unstable compilers. I was thinking more of
using some solid-but-not-ancient gcc release.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2019-04-11 15:52:25 Re: pgsql: Fix memory leak in pgbench
Previous Message Alvaro Herrera 2019-04-11 13:29:13 Re: pgsql: Fix declaration after statement