| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Jacob Brazeal <jacob(dot)brazeal(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Old BufferDesc refcount in PrintBufferDescs and PrintPinnedBufs |
| Date: | 2025-01-19 18:10:43 |
| Message-ID: | 7gtfx2lc6surct3v6gbgo6e4nnymuvnsbbbizyryfrnnrikec6@heuvirlj52b5 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2025-01-19 09:37:54 +0900, Michael Paquier wrote:
> On Fri, Jan 17, 2025 at 11:14:02PM -0800, Jacob Brazeal wrote:
> > Sounds good! v3 attached.
>
> Removal sounds good to me. Any objections from anybody?
>
> Andres, perhaps you have some experience using that and would prefer
> keep them and make them work?
I think they're pretty useless, tbh. There's too many buffers that just
printing them out is helpful - pg_buffercache is going to be a better
bet. When debugging issues where pg_buffercache isn't an option (e.g. because
it's a hang that doesn't allow running pg_buffercache), using
DebugPrintBufferRefcount() is much more targeted.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michail Nikolaev | 2025-01-19 18:26:58 | Re: Issue with markers in isolation tester? Or not? |
| Previous Message | Tom Lane | 2025-01-19 17:02:05 | Re: New feature request for adding session information to PostgreSQL transaction log |