Re: PL_stashcache, or, what's our minimum Perl version?

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: PL_stashcache, or, what's our minimum Perl version?
Date: 2017-07-31 20:22:43
Message-ID: 7fbd4508-23c5-f426-d374-6c72e20bbce9@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 7/31/17 15:38, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> One major PITA with the AC_PATH_* checks is that you can only override
>> them with environment variables that are full paths; otherwise the
>> environment variables are ignored. For example, currently, running
>
>> ./configure PYTHON=python3
>
>> will result in the PYTHON setting being ignored.
>
> Really? That seems pretty broken, independently of how many variables
> are affected. But the ones you'd be most likely to do that with are
> using AC_PATH_PROG already, I think. Having lesser-used program variables
> behave inconsistently doesn't seem like much of a win.

Well, if we're fiddling around here, I would change them all to
AC_CHECK_PROG if possible. Especially the PYTHON one annoys me all the
time. CC is another one I set occasionally.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-07-31 20:30:26 Re: [PATCH] Pattern based listeners for asynchronous messaging (LISTEN/NOTIFY)
Previous Message Markus Sintonen 2017-07-31 20:13:48 [PATCH] Pattern based listeners for asynchronous messaging (LISTEN/NOTIFY)