| From: | Christian Ullrich <chris(at)chrullrich(dot)net> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: VS 2015 support in src/tools/msvc |
| Date: | 2016-04-20 04:49:50 |
| Message-ID: | 7f93c690-5164-dc82-eb46-eee5afd98843@chrullrich.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
* Michael Paquier wrote:
> On Wed, Apr 20, 2016 at 1:48 AM, Christian Ullrich <chris(at)chrullrich(dot)net> wrote:
>> Both patches behave exactly the same in this test. Of the 102 remaining
>> locales, I get an unexpected codepage for just four:
>>
>> - kk: Expected 1251, used 1252
>> - kk-KZ: Expected 1251, used 1252
>> - sr: Expected 1251, used 1250
>> - uk: Expected 1251, used 1252
>>
>> I suspect that "sr" is a bug in MSDN: 1250 is Eastern European (Latin), 1251
>> is Cyrillic, and "sr" alone is listed as Latin. So either the script or the
>> codepage are likely wrong.
>
> Does VS2013 or older behave the same way for those locales? The patch
> using __crt_locale_data_public on VS2015 should work more or less
> similarly to VS2012~2013.
Identical results for unmodified master built with 2013.
--
Christian
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-04-20 05:03:16 | Re: VS 2015 support in src/tools/msvc |
| Previous Message | Noah Misch | 2016-04-20 04:39:26 | Re: VS 2015 support in src/tools/msvc |