Re: FOP warnings about id attributes in title tags

On 2/19/19 11:07 AM, Peter Eisentraut wrote:
> On 2019-02-18 16:37, Peter Eisentraut wrote:
>>> It appears that these are due to title elements having id tags. At
>>> <http://www.sagehill.net/docbookxsl/CrossRefs.html> is says:
>>>
>>> When adding an |id| or |xml:id| attribute, put it on the element
>>> itself, not the |title|.
>>>
>>> So maybe we need to fix those up?
>> You can't just remove the ids, since some of them are referenced from
>> elsewhere.
> Here was a discussion on getting rid of them:
> https://www.postgresql.org/message-id/flat/4a60dfc3-061b-01c4-2b86-279d3a612fd2%402ndquadrant.com
>

Yeah,

I did some experimentation, and found that removing the id on the title
tag, and the corresponding endterm attributes, and adding an xreflabel
to the linkend object seemed to have the desired effect. Not yet tested
with FOP but this looks like a good direction.

Test case:

diff --git a/doc/src/sgml/ref/alter_collation.sgml b/doc/src/sgml/ref/alter_collation.sgml
index b51b3a2564..432495e522 100644
--- a/doc/src/sgml/ref/alter_collation.sgml
+++ b/doc/src/sgml/ref/alter_collation.sgml
@@ -93,16 +93,15 @@ ALTER COLLATION <replaceable>name</replaceable> SET SCHEMA <replaceable>new_sche
     <listitem>
      <para>
       Update the collation's version.
-      See <xref linkend="sql-altercollation-notes"
-      endterm="sql-altercollation-notes-title"/> below.
+      See <xref linkend="sql-altercollation-notes"/> below.
      </para>
     </listitem>
    </varlistentry>
   </variablelist>
  </refsect1>
 
- <refsect1 id="sql-altercollation-notes">
-  <title id="sql-altercollation-notes-title">Notes</title>
+ <refsect1 id="sql-altercollation-notes" xreflabel="Notes">
+  <title>Notes</title>
 
   <para>
    When using collations provided by the ICU library, the ICU-specific version

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services