| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, fabriziomello(at)gmail(dot)com, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Subject: | Re: Minimal logical decoding on standbys |
| Date: | 2023-04-05 08:01:22 |
| Message-ID: | 7eef6187-e53d-2bd8-9f76-988f109a702c@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 4/4/23 8:13 PM, Jeff Davis wrote:
> On Tue, 2023-04-04 at 11:42 +0200, Drouvot, Bertrand wrote:
>> Done in V58 and now this is as simple as:
>
>
> Minor comments on 0004 (address if you agree):
>
Thanks for the review!
> * Consider static inline for WalSndWakeupProcessRequests()?
Agree and done in V60 just shared up-thread.
> * Is the WalSndWakeup() in KeepFileRestoredFromArchive() more like the
> flush case? Why is the second argument unconditionally true? I don't
> think the cascading logical walsenders have anything to do until the
> WAL is actually applied.
>
Agree and changed it to "(true, false)" in V60.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2023-04-05 08:01:56 | Re: Minimal logical decoding on standbys |
| Previous Message | Drouvot, Bertrand | 2023-04-05 07:59:24 | Re: Minimal logical decoding on standbys |