| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Unimpressed with pg_attribute_always_inline |
| Date: | 2018-01-09 01:09:27 |
| Message-ID: | 7ee7a4a2-1925-779a-28c1-48e5722d060f@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/8/18 19:56, Tom Lane wrote:
> Peter Geoghegan <pg(at)bowt(dot)ie> writes:
>> Anyway, ISTM that it should be possible to make
>> pg_attribute_always_inline have no effect in typical debug builds.
>> Wouldn't that make everyone happy?
>
> That would improve matters, but do we have access to the -O switch
> level as an #if condition?
See __OPTIMIZE__ and __NO_INLINE__ here:
https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html
However, at <https://gcc.gnu.org/onlinedocs/gcc/Inline.html> it says,
"GCC does not inline any functions when not optimizing unless you
specify the ‘always_inline’ attribute for the function". So,
apparently, if the goal is to turn off inlining when not optimizing,
then we should just use the normal inline attribute.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-01-09 01:13:17 | Re: Unimpressed with pg_attribute_always_inline |
| Previous Message | Masahiko Sawada | 2018-01-09 01:03:25 | Re: [HACKERS] Transactions involving multiple postgres foreign servers |