From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: confusing checkpoint_flush_after / bgwriter_flush_after |
Date: | 2016-11-25 19:54:55 |
Message-ID: | 7e9cace5-ef87-fad9-4498-80800dfce5f8@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 11/25/2016 06:10 PM, Tom Lane wrote:
> Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>>> #checkpoint_flush_after = 0 # 0 disables,
>>> # default is 256kB on linux, 0 otherwise
>
>>> I find this pretty confusing, because for all other GUCs in the file, the
>>> commented-out value is the default one. In this case that would mean "0",
>>> disabling the flushing.
>
>> Although I understand the issue, I'm not sure about -1 as a special value
>> to mean the default.
>
> Agreed --- I think that's making things more confusing not less.
>
> What we do in some similar cases is put the burden on initdb to fill in
> the correct value by modifying postgresql.conf.sample appropriately.
> It seems like that could be done easily here too. And it'd be a
> back-patchable fix.
>
I haven't realized initdb can do that. I agree that would be the best
solution.
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Stark | 2016-11-25 21:14:32 | Re: UNDO and in-place update |
Previous Message | Paul Ramsey | 2016-11-25 19:30:23 | User-defined Operator Pushdown and Collations |