| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: static assert cleanup |
| Date: | 2022-12-14 15:15:14 |
| Message-ID: | 7d41d99f-25ac-7673-9b4b-7601db7c1ddb@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11.12.22 23:18, Peter Smith wrote:
> +StaticAssertDecl(SysCacheSize == (int) lengthof(cacheinfo),
> + "SysCacheSize does not match syscache.c's array");
> +
> static CatCache *SysCache[SysCacheSize];
>
> In almost every example I found of StaticAssertXXX, the lengthof(arr)
> part came first in the condition. Since you are modifying this anyway,
> should this one also be reversed for consistency?
Makes sense. I have pushed this separately.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-12-14 15:55:31 | Re: Minimal logical decoding on standbys |
| Previous Message | Peter Eisentraut | 2022-12-14 13:39:43 | Re: Refactor SCRAM code to dynamically handle hash type and key length |