Reset the output buffer after sending from WalSndWriteData

From: Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Reset the output buffer after sending from WalSndWriteData
Date: 2025-02-20 20:49:46
Message-ID: 7c9c2f8d-ff29-48a6-bf1f-53fb278bc1ad@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I recently stumbled over an issue with an unintentional re-transmission.
While this clearly was our fault in the output plugin code, I think the
walsender's exposed API could easily be hardened to prevent the bad
consequence from this mistake.

Does anything speak against the attached one line patch?

Best Regards

Markus

Attachment Content-Type Size
0001-Reset-the-output-buffer-after-sending-from-WalSndWri.patch text/x-patch 1.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alena Rybakina 2025-02-20 21:09:27 Re: Replace IN VALUES with ANY in WHERE clauses during optimization
Previous Message Daniel Gustafsson 2025-02-20 20:37:13 Re: [PoC] Federated Authn/z with OAUTHBEARER