Re: meson vs windows perl

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Muralikrishna Bandaru <muralikrishna(dot)bandaru(at)enterprisedb(dot)com>, Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com>
Subject: Re: meson vs windows perl
Date: 2024-04-05 20:12:12
Message-ID: 7c4b6345-92b8-458d-ae3d-f7ba97ccdb01@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2024-04-05 Fr 10:12, Andrew Dunstan wrote:
>
> On 2024-04-05 Fr 08:25, Andrew Dunstan wrote:
>>
>>
>>
>> Here is an attempt to fix all that. It's ugly, but I think it's more
>> principled.
>>
>> First, instead of getting the ldopts and then trying to filter out
>> the ldflags and ccdlflags, it tells perl not to include those in the
>> first place, by overriding a couple of routines in ExtUtils::Embed.
>> And second, it's smarter about splitting what's left, so that it
>> doesn't split on a space that's in a quoted item. The perl that's
>> used to do that second bit is not pretty, but it has been tested on
>> the system where the problem arose and apparently cures the problem.
>> (No doubt some perl guru could improve it.) It also works on my
>> Ubuntu system, so I don't think we'll be breaking anything (famous
>> last words).
>>
>>
>
> Apparently I spoke too soon. Please ignore the above for now.
>
>
>

OK, this has been fixed and checked. The attached is what I propose.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachment Content-Type Size
ldopts3.patch text/x-patch 1.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-04-05 20:34:06 Re: Fixing backslash dot for COPY FROM...CSV
Previous Message Andrew Dunstan 2024-04-05 20:09:58 Re: WIP Incremental JSON Parser