Re: pgsql: Fix createdb tests for C locale

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christoph Berg <myon(at)debian(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix createdb tests for C locale
Date: 2022-09-21 01:03:06
Message-ID: 7c298d81-5a35-cfae-2f1e-2852214dcb8e@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 2022-09-19 Mo 15:46, Peter Eisentraut wrote:
> On 17.09.22 16:44, Tom Lane wrote:
>> Christoph Berg <myon(at)debian(dot)org> writes:
>>> This seems to have broken 15 on apt.pg.o/Debian:
>>
>> Fails on RHEL8 too, if LANG=C.
>> OK if LANG=C.utf8.
>>
>> (The lack of buildfarm complaints is distressing.  Apparently
>> our coverage of ICU is very thin.)
>
> This issue is with a combination of ICU and environment locale "C".
> There is ICU coverage in the build farm, but apparently none with C
> locale set.
>
>

Yep, it's been like that for 5 years, ever since we added support for
the ICU collation test. See
<https://github.com/PGBuildFarm/client-code/blob/main/PGBuild/Modules/TestICU.pm>
line 59:

    return unless $locale =~ /utf8/i;

We can change that of course, I'm open to suggestions.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-09-21 01:11:30 pgsql: Add definition pg_attribute_aligned() for MSVC
Previous Message Tom Lane 2022-09-20 23:00:24 pgsql: Disable -Wdeprecated-non-prototype in the back branches.