From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
---|---|
To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
Cc: | Geoff Winkless <pgsqladmin(at)geoff(dot)dj>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: late binding of shared libs for C functions |
Date: | 2018-06-12 12:49:58 |
Message-ID: | 7c1e9c87-80a0-2fd1-e5da-66b35ec8ee60@2ndQuadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 06/12/2018 08:46 AM, Andrew Gierth wrote:
>>>>>> "Andrew" == Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> Andrew> Perhaps something like NO CHECK would meet the case, i.e. we're
> Andrew> not checking the link at function creation time.
>
> The real question is why check_function_bodies doesn't cover this;
> there's a comment in fmgr_c_validator that this is deliberate, but it's
> rather unclear what the advantage is supposed to be:
>
> * It'd be most consistent to skip the check if !check_function_bodies,
> * but the purpose of that switch is to be helpful for pg_dump loading,
> * and for pg_dump loading it's much better if we *do* check.
>
Maybe we need a function that will validate all the links, that could be
called after everything is installed.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2018-06-12 13:10:50 | Re: Avoid extra Sort nodes between WindowAggs when sorting can be reused |
Previous Message | Andrew Gierth | 2018-06-12 12:46:55 | Re: late binding of shared libs for C functions |