From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | David Steele <david(at)pgmasters(dot)net>, Sergei Kornilov <sk(at)zsrv(dot)org>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: recovery_target_action=pause with confusing hint |
Date: | 2020-03-09 16:03:13 |
Message-ID: | 7bdf63fd-30b3-db76-e700-7eca0838b30a@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2020/03/09 21:30, David Steele wrote:
> Hi Sergei,
>
> On 1/30/20 12:00 PM, Fujii Masao wrote:
>>
>>> - check for standby triggers only for recovery_target_action - I am not sure this would be safe for pg_wal_replay_pause() call case
>>
>> Agreed. Basically I think that recoveryPausesHere() should the promotion
>> trigger whether recovery target is reached or not. But one question is;
>> how should the recovery behave if recovery target is reached with
>> recovery_target_action=pause after the promotion is requested?
>> It should pause? Or promote?
>
> Do you have thoughts on Fujii's comments?
Thanks for the ping! And sorry for not reporting the current status.
I started the discussion about the topic very related to this.
I'm thinking to apply the change that Sergei proposes after applying
the patch I attached in this thread.
https://postgr.es/m/00c194b2-dbbb-2e8a-5b39-13f14048ef0a@oss.nttdata.com
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2020-03-09 16:07:07 | Re: Remove utils/acl.h from catalog/objectaddress.h |
Previous Message | Robert Haas | 2020-03-09 15:59:28 | Re: Atomics in localbuf.c |