| From: | Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | Jim Nasby <jnasby(at)upgrade(dot)com>, Andrei Zubkov <zubkov(at)moonset(dot)ru>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, a(dot)lepikhov(at)postgrespro(dot)ru |
| Subject: | Re: Vacuum statistics |
| Date: | 2024-12-02 20:59:58 |
| Message-ID: | 7b6a06d4-0d37-4340-999b-47a2a6eca033@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi! Thank you for your review!
On 30.11.2024 07:48, Kirill Reshke wrote:
> Hello!
> After a brief glance, I think this patch set is good.
> But there isn't any more time in the current CF to commit this :(.
> So I moved to the next CF.
I agree with you. Thank you!)
> I also like the 0001 commit message. This commit message is quite
> large and easy to understand. Actually, it might be too big. Perhaps
> rather of being a commit message, the final paragraph (pages_frozen -
> number of pages that..) need to be a part of the document. Perhaps
> delete the explanation on pages_frozen that we have in 0004?
To be honest, I don't quite understand what you're suggesting. Are you
suggesting moving the explanation about the pages_frozen from the commit
message to the documentation or fixing something in the documentation
about the pages_frozen? Can you please explain?
--
Regards,
Alena Rybakina
Postgres Professional
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alena Rybakina | 2024-12-02 21:00:37 | Re: Vacuum statistics |
| Previous Message | Peter Geoghegan | 2024-12-02 20:59:36 | Re: Incorrect result of bitmap heap scan. |