| From: | Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com> |
|---|---|
| To: | Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>, Andrei Zubkov <zubkov(at)moonset(dot)ru> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, a(dot)lepikhov(at)postgrespro(dot)ru |
| Subject: | Re: Vacuum statistics |
| Date: | 2024-08-15 09:50:58 |
| Message-ID: | 7ac0e5c5-86ca-4301-af5e-b107e4ff0a58@tantorlabs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 15.8.24 11:49, Alena Rybakina wrote:
>>
>> I have some suggestions:
>>
>> 1. pgstatfuncs.c in functions tuplestore_put_for_database() and
>> tuplestore_put_for_relation you can remove 'nulls' array if
>> you're sure that columns cannot be NULL.
>>
> We need to use this for tuplestore_putvalues function. With this
> function, we fill the table with the values of the statistics.
Ah, right! I'm sorry.
>> 1.
>>
>>
>>
>> 2. These functions are almost the same and I would think of writing
>> one function depending of type 'ExtVacReportType'
>>
> I'm not sure that I fully understand what you mean. Can you explain it
> more clearly, please?
Ah, I didn't notice that the size of all three tables is different.
Therefore, it won't be possible to write one function instead of two to
avoid code duplication. My mistake.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2024-08-15 09:56:09 | Re: Optimize mul_var() for var1ndigits >= 8 |
| Previous Message | Jeff Davis | 2024-08-15 08:57:03 | Re: Statistics Import and Export |