Re: Use more CppAsString2() in pg_amcheck.c

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use more CppAsString2() in pg_amcheck.c
Date: 2024-10-18 09:59:48
Message-ID: 7DBF8BF1-AFD8-4460-9F3B-5B15BA5FE3BA@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 18 Oct 2024, at 11:50, Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> pg_amcheck.c is one of these places where relkind and relpersistence
> values are hardcoded in queries based on the contents of pg_class_d.h.
> Similarly to other places in src/bin/, let's sprinkle some
> CppAsString2() and feed to the binary the values from the header. The
> patch attached does that.

I haven't studied the patch in detail (yet), nothing stood out from a quick
skim, but +1 on the concept.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2024-10-18 10:04:12 Re: Enhance create subscription reference manual
Previous Message Michael Paquier 2024-10-18 09:50:50 Use more CppAsString2() in pg_amcheck.c