From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Add version and data directory to initdb output |
Date: | 2022-04-19 09:28:42 |
Message-ID: | 7C749AC3-176A-4622-98EA-D5A852A078D9@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 16 Apr 2022, at 01:50, David G. Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> initdb is already pretty chatty, and the version of the cluster being installed seems useful to include as well.
That seems quite reasonable.
> The data directory is probably less so - though I am thinking that the absolute path would be useful to report, especially when a relative path is specified (I didn't figure that part out yet, figured I'd get the idea approved before working out how to make it happen).
I'm less convinced that it will be worth the additional code to make it
portable across *nix/Windows etc.
> Moving "Success" to that "summary output" line and leaving the optional shell command line just be the shell command made sense to me.
Looking at the output, couldn't it alternatively be printed grouped with the
other info on the cluster, ie the final three rows in the example below:
./bin/initdb -D data
The files belonging to this database system will be owned by user "<username>".
This user must also own the server process.
The database cluster will be initialized with locale "en_US.UTF-8".
The default database encoding has accordingly been set to "UTF8".
The default text search configuration will be set to "english".
How about 'The database cluster will be initialized with version "14.2".' added
there, which then can keep the "Success" line in place in case existing scripts
are triggering on that line?
--
Daniel Gustafsson https://vmware.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2022-04-19 09:46:11 | Re: Stabilizing the test_decoding checks, take N |
Previous Message | Kyotaro Horiguchi | 2022-04-19 09:25:18 | Re: TRAP: FailedAssertion("tabstat->trans == trans", File: "pgstat_relation.c", Line: 508 |