| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Tels <nospam-pg-abuse(at)bloodgate(dot)com> |
| Cc: | Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [WIP PATCH] Index scan offset optimisation using visibility map |
| Date: | 2018-03-07 06:11:27 |
| Message-ID: | 7C1D5AF6-DA3A-4B43-A3CF-25432DFF0F76@yandex-team.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> 7 марта 2018 г., в 3:25, Tels <nospam-pg-abuse(at)bloodgate(dot)com> написал(а):
>
> It could be named "SkipTuples" (e.g. this is the number of tuples we need
> to skip, not the number we have skipped), and the other one then
> "iss_SkipTuplesRemaining" so they are consistent with each other.
I agree that name sounds strange (even for my globish ear).
I'm not sure, but may be this
! Assert(!(scandesc->numberOfOrderBys > 0 && scandesc->xs_recheckorderby));
should be if() elog(ERROR,...); ?
Also, I think that this check could be removed from loop. We do not expect that it's state will change during execution, do we?
Besides this, I think the patch is ready for committer.
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tsunakawa, Takayuki | 2018-03-07 06:15:24 | RE: Speed up the removal of WAL files |
| Previous Message | Ashutosh Bapat | 2018-03-07 06:00:53 | Missing break statement after transformCallStmt in transformStmt |