From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>,Robert Haas <robertmhaas(at)gmail(dot)com>,Christoph Berg <myon(at)debian(dot)org>,PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
Date: | 2020-01-05 16:48:18 |
Message-ID: | 7AFCA08A-309A-45B8-95A9-7B7067FC5B5B@ilmari.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 5 January 2020 16:38:36 GMT, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>ilmari(at)ilmari(dot)org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
>> Here's one final style cleanup for the TAP test.
>
>LGTM, pushed.
Thanks!
>One minor note: you wanted to change the \DRD test to
>
>+check_completion("\\DRD\t", qr/\\drds /, "complete \\DRD<tab> to
>\\drds");
>
>but that doesn't work everywhere, unfortunately. On my machine
>what comes out is
>
># Actual output was "\\DRD\b\b\bdrds "
># Did not match "(?-xism:\\drds )"
Sorry, that was something I left in for testing the diagnostic and forgot to remove before committing.
> regards, tom lane
- ilmari
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-01-05 18:30:42 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
Previous Message | Tom Lane | 2020-01-05 16:38:36 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-01-05 17:33:10 | Re: Rethinking opclass member checks and dependency strength |
Previous Message | Tom Lane | 2020-01-05 16:38:36 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |