Re: New "raw" COPY format

On Mon, Oct 14, 2024, at 21:59, Joel Jacobson wrote:
> On Mon, Oct 14, 2024, at 10:51, Joel Jacobson wrote:
>> On Mon, Oct 14, 2024, at 10:07, Joel Jacobson wrote:
>>> Attached is a first draft implementation of the new proposed COPY "raw" format.
>>>
>>> The first two patches are just the bug fix in HEAD, reported separately:
>>> https://commitfest.postgresql.org/50/5297/

I noticed tests were failing in cfbot,
which surprised me since tests were passing locally,
but it was due to me not running the full test suite.

Sorry about the noise. I'm not running the full test suite,
with tap and `meson test --num-processes 32`,
so hopefully I won't cause cfbot failures as often any longer.

(The bug was due to an invalid assert; I wrongly assumed
Assert(opts_out->quote) would be sane inside the
if (opts_out->default_print) branch, but it is of course
wrong, since quote is NULL for the text format,
and the quote check was only performed if format was CSV,
so the assert was unnecessary and invalid).

I've also change the :filename I'm using in copy2.sql
for the raw format tests, to not be the same as in copy.sql,
since I guess this could cause problems with tests
running in parallell.

I've now split the reorganization of ProcessCopyOptions,
into separate easily small steps to make it easier to review.

Each step breaks out the validation of a COPY option,
into its own section, except for DELIMITER and NULL
that had to be changed together in a single commit.

/Joel