Re: Subscription code improvements

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Subscription code improvements
Date: 2017-08-03 17:17:23
Message-ID: 79a1ff3e-e767-13b5-5dbc-5020106b7509@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 7/13/17 23:53, Masahiko Sawada wrote:
> To summary, I think we now have only one issue; ALTER SUBSCRIPTION is
> not transactional, 0004 patch is addressing this issue .

We have two competing patches for this issue. This patch moves the
killing to the end of the DDL transaction. Your earlier patch makes the
tablesync work itself responsible for exiting. Do you wish to comment
which direction to pursue? (Doing both might also be an option?)

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-08-03 17:23:19 Re: Cache lookup errors with functions manipulation object addresses
Previous Message Robert Haas 2017-08-03 17:13:16 Re: foreign table creation and NOT VALID check constraints