Re: question on some code.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Chris Bowlby <excalibur(at)accesswave(dot)ca>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: question on some code.
Date: 2005-07-19 18:22:40
Message-ID: 7995.1121797360@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Chris Bowlby <excalibur(at)accesswave(dot)ca> writes:
> I understand the concept of the code, to append binary values to a string
> buffer (char *), but, under my compiler on FreeBSD 5.4.x (gcc (GCC) 3.4.2
> [FreeBSD] 20040728) I see a few issues that have cropped up.

You've got a broken compiler then, because it certainly works for
everyone else. That function's been substantially unchanged since
... hmm ... version 1.1 of pqformat.c dated 25 Apr 1999. And I'm
fairly sure that I got it from some older code rather than writing
it from scratch when I made that file.

> Through some testing that I've been doing (outputting the values in
> the appendBinaryStringInfo function), I never seem to see any data, The
> variable pointer that references the "n8, n16, or n32" value is not holding
> any data in the appendBinaryStringInfo function.

Define "never seem to see any data"...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-07-19 18:29:08 Re: Buildfarm issues on specific machines
Previous Message Larry Rosenman 2005-07-19 18:16:24 Re: config.sub/config.guess.